Set analytics custom dimensions from govuk: meta tags
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Find `govuk:` namespaced meta tags * Use content of these tags to set dimensions * Be explicit about what's being read and set * Works with both old and new slimmer versions
Only version below 8.0.0 insert these old custom variables. When all apps have been updated to use a modern slimmer this template can be removed entirely.
| @@ -78,6 +79,26 @@ | |||
| tracker.setDimension(customVar[1], customVar[3], customVar[2], customVar[4]); | |||
| } | |||
|
|
|||
| function setDimensionsFromMetaTags() { | |||
There was a problem hiding this comment.
Is there any reason this method can't be added to the prototype? That would save the awkward apply(this) line above and would better follow the approach we suggest in the JavaScript styleguide.
There was a problem hiding this comment.
I saw no reason to add setDimensionsFromMetaTags to the public api as its only use is during initialisation.
There was a problem hiding this comment.
Adding it to the public api would let us add proper unit tests to just this method. Which if it is private we can't do. Also while there is no need for this to be added to the public api there is also no harm in it being public. I would lean on the side of making JavaScript methods public unless there is a good reason not to.
* Avoid need for `.apply` * Be more lenient in what can access this method
edds
added a commit
that referenced
this pull request
Mar 13, 2015
Set analytics custom dimensions from `govuk:` meta tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to alphagov/slimmer#119
govuk:namespaced meta tags and use the content of these tags to set dimensions